Tweak nominal scale axes akin to categorical axes in classic seaborn #3069
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2967
Three changes:
Current:
With this change:
We'll want to allow users to override the grid parameterization. I think we'll need an API for that that is separate from
Plot.theme
and I'm not exactly sure where it should be off the top of my head.Plot.layout
or on theNominal
object itself are two ideas.I'd also still like this to be supported as a first-class operation in matplotlib, but I'm not sure how likely that is.
It feels like a bit of a hack to have this logic live in
Plot._finalize_figure
with an instance check on the Scale. Alternatively, we could put the logic in the Scale object and have_finalize_figure
call into it. Maybe something to revisit once we either want other scale-specific tweaks or when the extension API is formally opened up.