Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover full extent of data in Band/Range when not given min/max explicitly #3056

Merged
merged 3 commits into from
Oct 8, 2022

Conversation

mwaskom
Copy link
Owner

@mwaskom mwaskom commented Oct 5, 2022

(
    seaice
    .assign(Year=df["Date"].dt.year)
    .pipe(so.Plot, x="Year", y="Extent")
    .add(so.Band())
    .add(so.Range())
)

Closes #3024

@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Merging #3056 (f4d1254) into master (5386adc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3056   +/-   ##
=======================================
  Coverage   98.37%   98.38%           
=======================================
  Files          72       72           
  Lines       23503    23537   +34     
=======================================
+ Hits        23121    23156   +35     
+ Misses        382      381    -1     
Impacted Files Coverage Δ
seaborn/_marks/area.py 96.51% <100.00%> (+0.17%) ⬆️
seaborn/_marks/line.py 100.00% <100.00%> (ø)
tests/_marks/test_area.py 100.00% <100.00%> (ø)
tests/_marks/test_line.py 100.00% <100.00%> (ø)
seaborn/_core/scales.py 89.67% <0.00%> (+0.23%) ⬆️

@mwaskom mwaskom merged commit 6d6f8d3 into master Oct 8, 2022
@mwaskom mwaskom deleted the mark/auto_range branch October 8, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider having range mark derive min/max from data when not given
1 participant