Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert color palette docstrings to notebooks #3034

Merged
merged 9 commits into from
Sep 19, 2022
Merged

Convert color palette docstrings to notebooks #3034

merged 9 commits into from
Sep 19, 2022

Conversation

mwaskom
Copy link
Owner

@mwaskom mwaskom commented Sep 18, 2022

This completes the removal of doctest-style examples from the seaborn codebase, so testing infrastructure complexity distinguishing between unit/doc tests is also removed. Closes #2110

Additionally:

  • make various docstring improvements
  • provide better feedback for the colormap widgets when ipywidgets is not installed.

@mwaskom mwaskom added this to the v0.12.1 milestone Sep 18, 2022
@codecov
Copy link

codecov bot commented Sep 18, 2022

Codecov Report

Merging #3034 (d7fa812) into master (54c36b7) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3034      +/-   ##
==========================================
- Coverage   98.32%   98.25%   -0.08%     
==========================================
  Files          69       69              
  Lines       23241    23270      +29     
==========================================
+ Hits        22852    22864      +12     
- Misses        389      406      +17     
Impacted Files Coverage Δ
seaborn/rcmod.py 100.00% <ø> (ø)
seaborn/palettes.py 99.60% <100.00%> (+0.03%) ⬆️
tests/test_palettes.py 100.00% <100.00%> (ø)
seaborn/objects.py 0.00% <0.00%> (-100.00%) ⬇️
seaborn/_docstrings.py 85.36% <0.00%> (-14.64%) ⬇️
seaborn/_compat.py 46.46% <0.00%> (+1.01%) ⬆️

@mwaskom mwaskom merged commit e644793 into master Sep 19, 2022
@mwaskom mwaskom deleted the palettes/docs branch September 19, 2022 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move away from doctest-style examples
1 participant