Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add label parameter to pointplot #3016

Merged
merged 4 commits into from
Oct 12, 2022
Merged

Add label parameter to pointplot #3016

merged 4 commits into from
Oct 12, 2022

Conversation

mwaskom
Copy link
Owner

@mwaskom mwaskom commented Sep 12, 2022

Unbreaks FacetGrid + pointplot (fixes #3004) and is generally useful.

g = sns.FacetGrid(tips, col="sex", hue="time")
g.map(sns.pointplot, "day", "total_bill")
g.add_legend()

image

Nevertheless, using pointplot and FacetGrid directly is still discouraged, prefer catplot.

Unbreaks FacetGrid + pointplot (fixes #3004) and is generally useful.
@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #3016 (dc4829c) into master (54cab15) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3016   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files          74       74           
  Lines       23648    23657    +9     
=======================================
+ Hits        23267    23276    +9     
  Misses        381      381           
Impacted Files Coverage Δ
seaborn/categorical.py 98.54% <100.00%> (+<0.01%) ⬆️
tests/test_categorical.py 99.77% <100.00%> (+<0.01%) ⬆️

@mwaskom mwaskom merged commit 85c8ed6 into master Oct 12, 2022
@mwaskom mwaskom deleted the fix/pointplot_label branch October 12, 2022 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FacetGrid.map_dataframe passes disallowed keyword arguments to pointplot
1 participant