Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Make PolyFit stat robust to missing data #3010

Merged
merged 2 commits into from
Sep 12, 2022
Merged

Fix: Make PolyFit stat robust to missing data #3010

merged 2 commits into from
Sep 12, 2022

Conversation

mwaskom
Copy link
Owner

@mwaskom mwaskom commented Sep 11, 2022

Fixes #2992

@mwaskom mwaskom added this to the v0.12.1 milestone Sep 11, 2022
@codecov
Copy link

codecov bot commented Sep 11, 2022

Codecov Report

Merging #3010 (f191292) into master (0f5a013) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3010   +/-   ##
=======================================
  Coverage   98.32%   98.33%           
=======================================
  Files          69       69           
  Lines       23230    23237    +7     
=======================================
+ Hits        22842    22849    +7     
  Misses        388      388
Impacted Files Coverage Δ
seaborn/_stats/regression.py 95.65% <100.00%> (ø)
tests/_stats/test_regression.py 100.00% <100.00%> (ø)

@mwaskom mwaskom merged commit c5c5f4a into master Sep 12, 2022
@mwaskom mwaskom deleted the fix/polyfit_na branch September 12, 2022 00:24
@mwaskom mwaskom mentioned this pull request Oct 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix objects-stat
Projects
None yet
Milestone
v0.12.1
Development

Successfully merging this pull request may close these issues.

PolyFit is not robust to missing data
1 participant
@mwaskom