Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Scatter mark to Dots #2942

Merged
merged 5 commits into from
Aug 7, 2022
Merged

Rename Scatter mark to Dots #2942

merged 5 commits into from
Aug 7, 2022

Conversation

mwaskom
Copy link
Owner

@mwaskom mwaskom commented Aug 6, 2022

Scatter was the first mark added for prototyping before much though about general naming schemes. We've since settled on a pattern where a plural form of a mark indicates that the mark is better suited to plots where it will appear many times. This scheme applies to the Dot/Scatter relationship too, so best to be consistent. Dots is also almost half as long as Scatter. It's also good in that Scatter did not produce plots that looked particularly like the existing scatterplot.

The scatter.py module is now accordingly changed to dot.py.

As part of the change, refactored the relationship between Dot and Dots so that they depend on a common base rather than having one inherit from the other.

@mwaskom mwaskom added this to the v0.12.0 milestone Aug 6, 2022
@codecov
Copy link

codecov bot commented Aug 6, 2022

Codecov Report

Merging #2942 (b9f185f) into master (9771eae) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2942   +/-   ##
=======================================
  Coverage   98.30%   98.30%           
=======================================
  Files          69       69           
  Lines       22985    22996   +11     
=======================================
+ Hits        22596    22607   +11     
  Misses        389      389           
Impacted Files Coverage Δ
seaborn/_core/properties.py 99.15% <ø> (ø)
seaborn/_marks/dot.py 100.00% <100.00%> (ø)
seaborn/objects.py 100.00% <100.00%> (ø)
tests/_marks/test_dot.py 100.00% <100.00%> (ø)

@mwaskom mwaskom merged commit a1ede5e into master Aug 7, 2022
@mwaskom mwaskom deleted the rename/scatter branch August 7, 2022 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant