Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the legend argument of categorical scatterplots #2933

Merged
merged 5 commits into from
Aug 3, 2022

Conversation

MaozGelbart
Copy link
Contributor

The legend argument was added in #2828 but is not documented (it is mentioned in the release notes). This PR documents this argument, and uses it in the docstrings and one stripplot example.

@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #2933 (dac54fa) into master (f581300) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2933   +/-   ##
=======================================
  Coverage   98.24%   98.24%           
=======================================
  Files          69       69           
  Lines       22866    22898   +32     
=======================================
+ Hits        22464    22496   +32     
  Misses        402      402           
Impacted Files Coverage Δ
seaborn/categorical.py 98.53% <ø> (ø)
tests/test_axisgrid.py 99.37% <0.00%> (+<0.01%) ⬆️
seaborn/axisgrid.py 97.18% <0.00%> (+0.01%) ⬆️
seaborn/utils.py 95.08% <0.00%> (+0.11%) ⬆️

Copy link
Owner

@mwaskom mwaskom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

seaborn/categorical.py Outdated Show resolved Hide resolved
seaborn/categorical.py Outdated Show resolved Hide resolved
@mwaskom
Copy link
Owner

mwaskom commented Aug 3, 2022

Nice catch, thanks!

@mwaskom mwaskom merged commit ff96e1f into mwaskom:master Aug 3, 2022
@MaozGelbart MaozGelbart deleted the cat_scat_legend branch August 3, 2022 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants