Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store figsize in _figure_spec object #2917

Merged
merged 1 commit into from
Jul 24, 2022
Merged

Store figsize in _figure_spec object #2917

merged 1 commit into from
Jul 24, 2022

Conversation

mwaskom
Copy link
Owner

@mwaskom mwaskom commented Jul 22, 2022

Fixes #2891

@mwaskom mwaskom added this to the v0.12.0 milestone Jul 22, 2022
@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #2917 (76899f3) into master (1524d43) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2917   +/-   ##
=======================================
  Coverage   98.20%   98.20%           
=======================================
  Files          69       69           
  Lines       22666    22672    +6     
=======================================
+ Hits        22260    22266    +6     
  Misses        406      406           
Impacted Files Coverage Δ
seaborn/_core/plot.py 94.96% <100.00%> (+0.01%) ⬆️
tests/_core/test_plot.py 98.45% <100.00%> (+<0.01%) ⬆️

@mwaskom mwaskom merged commit d33ab67 into master Jul 24, 2022
@mwaskom mwaskom deleted the fix/clone_figsize branch July 24, 2022 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plot.configure figsize doesn't persist if it's not the final method called
1 participant