Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make scale config apply to variables computed by the stat transform #2915

Merged
merged 7 commits into from
Jul 24, 2022

Conversation

mwaskom
Copy link
Owner

@mwaskom mwaskom commented Jul 20, 2022

  • Refactors _transform_coords and _setup_scales into one method.
  • Properly handles scale config for coordinate variables that are computed during the stat
  • Properly handles scale config when only coordinate ranges are defined

Fixes #2908, fixes #2885

@mwaskom mwaskom added this to the v0.12.0 milestone Jul 20, 2022
@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #2915 (1ab0e55) into master (1524d43) will increase coverage by 0.01%.
The diff coverage is 98.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2915      +/-   ##
==========================================
+ Coverage   98.20%   98.22%   +0.01%     
==========================================
  Files          69       69              
  Lines       22666    22694      +28     
==========================================
+ Hits        22260    22291      +31     
+ Misses        406      403       -3     
Impacted Files Coverage Δ
seaborn/_core/plot.py 95.33% <97.40%> (+0.39%) ⬆️
seaborn/_compat.py 30.26% <100.00%> (+1.88%) ⬆️
tests/_core/test_plot.py 98.49% <100.00%> (+0.04%) ⬆️

@mwaskom mwaskom merged commit b5a85ff into master Jul 24, 2022
@mwaskom mwaskom deleted the scale/computed branch July 24, 2022 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant