Don't modify patch.facecolor in set_palette #2906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matplotlib's default is now C0, so the facecolor should match the first color in th cycle by default. crossref: #2901
Codecov Report
@@ Coverage Diff @@
## master #2906 +/- ##
=======================================
Coverage 98.20% 98.20%
=======================================
Files 69 69
Lines 22625 22625
=======================================
Hits 22219 22219
Misses 406 406
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matplotlib's default is now C0, so the facecolor should match the first
color in the cycle by default.
crossref: #2901