Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade exception on mapping list length mismatch to warning #2856

Merged
merged 4 commits into from
Jun 15, 2022

Conversation

mwaskom
Copy link
Owner

@mwaskom mwaskom commented Jun 13, 2022

Closes #2662

This makes the current behavior of functions that use the old core machinery consistent with the objects interface, so there should be a smooth transition once they are refactored.

@mwaskom mwaskom added this to the v0.12.0 milestone Jun 13, 2022
@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #2856 (75e337a) into master (762bd3b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2856   +/-   ##
=======================================
  Coverage   98.12%   98.12%           
=======================================
  Files          69       69           
  Lines       22251    22255    +4     
=======================================
+ Hits        21834    21838    +4     
  Misses        417      417           
Impacted Files Coverage Δ
seaborn/_oldcore.py 97.67% <100.00%> (+0.01%) ⬆️
tests/test_axisgrid.py 99.36% <100.00%> (ø)
tests/test_core.py 99.68% <100.00%> (ø)

@mwaskom mwaskom merged commit 563e96d into master Jun 15, 2022
@mwaskom mwaskom deleted the core/palette_size branch June 15, 2022 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValueError: The palette list has the wrong number of colors.
1 participant