Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherit errorbar alpha from scatter points in regplot #2853

Merged
merged 2 commits into from
Jun 12, 2022

Conversation

mwaskom
Copy link
Owner

@mwaskom mwaskom commented Jun 12, 2022

Closes #2540 by adding a test. Closes #2538.

sns.regplot(
    tips, x="size", y="total_bill",
    x_estimator=np.mean, scatter_kws={"alpha": .5}
)

image

milo-trujillo and others added 2 commits June 12, 2022 10:27
x_estimator error bars were previously always opaque, but now inherit alpha settings from scatterplot settings, since the error bars replace the scatterplot
@codecov
Copy link

codecov bot commented Jun 12, 2022

Codecov Report

Merging #2853 (1c84c9a) into master (a674a83) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2853   +/-   ##
=======================================
  Coverage   98.12%   98.12%           
=======================================
  Files          69       69           
  Lines       22221    22228    +7     
=======================================
+ Hits        21804    21811    +7     
  Misses        417      417           
Impacted Files Coverage Δ
seaborn/regression.py 99.07% <100.00%> (+<0.01%) ⬆️
tests/test_regression.py 99.53% <100.00%> (+<0.01%) ⬆️

@mwaskom mwaskom merged commit fe9fad8 into master Jun 12, 2022
@mwaskom mwaskom deleted the regplot/error_alpha branch June 12, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lmplot/regplot can't set alpha of x_estimator
2 participants