Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't remove top left ylabel from corner pairplot with normal diagonal #2850

Merged
merged 1 commit into from
Jun 11, 2022

Conversation

mwaskom
Copy link
Owner

@mwaskom mwaskom commented Jun 11, 2022

Closes #2772. Because PairGrid.map_diag has logic to disable the y axis visibility when corner=True, there's no reason to remove the y axis label when setting up the plot.

@codecov
Copy link

codecov bot commented Jun 11, 2022

Codecov Report

Merging #2850 (e0048e4) into master (7b3e4df) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2850      +/-   ##
==========================================
- Coverage   98.04%   98.04%   -0.01%     
==========================================
  Files          69       69              
  Lines       22242    22240       -2     
==========================================
- Hits        21807    21805       -2     
  Misses        435      435              
Impacted Files Coverage Δ
seaborn/axisgrid.py 96.04% <ø> (-0.01%) ⬇️
tests/test_axisgrid.py 99.36% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b3e4df...e0048e4. Read the comment docs.

@mwaskom mwaskom merged commit ba0eda0 into master Jun 11, 2022
@mwaskom mwaskom deleted the pairplot/corner_ylabel branch June 11, 2022 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing axis label in pairplot
1 participant