Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop missing data centrally while allowing marks to disable #2816

Merged
merged 1 commit into from
May 22, 2022

Conversation

mwaskom
Copy link
Owner

@mwaskom mwaskom commented May 22, 2022

I'm not totally certain what the best approach to missing data is; this will drop missing data after stats and scaling. I don't think seaborn needs explicit functionality for considering "missing" a valid category (it is just as easy to do df.fillna("missing")) but there may be times when it is desired to have missing data represented with (invisible) artists.

For now, that's not externally parametrize, but it is possible for a specific Mark to implement that behavior.

@mwaskom mwaskom added this to the v0.12.0 milestone May 22, 2022
@codecov
Copy link

codecov bot commented May 22, 2022

Codecov Report

Merging #2816 (693aa4b) into master (34b8873) will decrease coverage by 0.00%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master    #2816      +/-   ##
==========================================
- Coverage   97.96%   97.96%   -0.01%     
==========================================
  Files          67       67              
  Lines       21756    21772      +16     
==========================================
+ Hits        21313    21328      +15     
- Misses        443      444       +1     
Impacted Files Coverage Δ
seaborn/_marks/basic.py 60.86% <25.00%> (-1.04%) ⬇️
seaborn/_core/plot.py 95.11% <100.00%> (+0.02%) ⬆️
seaborn/_core/properties.py 99.15% <100.00%> (+<0.01%) ⬆️
seaborn/_marks/scatter.py 100.00% <100.00%> (ø)
seaborn/tests/_marks/test_scatter.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34b8873...693aa4b. Read the comment docs.

@mwaskom mwaskom merged commit 995ea1c into master May 22, 2022
@mwaskom mwaskom deleted the nextgen/dropna branch May 22, 2022 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant