Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix histplot binwidth edgecases #2813

Merged
merged 4 commits into from
May 18, 2022
Merged

Fix histplot binwidth edgecases #2813

merged 4 commits into from
May 18, 2022

Conversation

mwaskom
Copy link
Owner

@mwaskom mwaskom commented May 18, 2022

Fixes #2721
Fixes #2785

These actually ended up being slightly distinct issues, although they can be fixed in the same block of code.

@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #2813 (9441604) into master (60e58eb) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2813   +/-   ##
=======================================
  Coverage   97.96%   97.96%           
=======================================
  Files          67       67           
  Lines       21745    21756   +11     
=======================================
+ Hits        21302    21313   +11     
  Misses        443      443           
Impacted Files Coverage Δ
seaborn/axisgrid.py 96.05% <ø> (ø)
seaborn/regression.py 98.15% <ø> (ø)
seaborn/_statistics.py 100.00% <100.00%> (ø)
seaborn/tests/test_statistics.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60e58eb...9441604. Read the comment docs.

@mwaskom mwaskom force-pushed the fix/hist_missing_bin branch from 796e89a to 5ffcabb Compare May 18, 2022 01:00
@mwaskom mwaskom merged commit 34b8873 into master May 18, 2022
@mwaskom mwaskom deleted the fix/hist_missing_bin branch May 18, 2022 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant