Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize cache directory #2773

Merged
merged 1 commit into from
Apr 3, 2022
Merged

Standardize cache directory #2773

merged 1 commit into from
Apr 3, 2022

Conversation

Freed-Wu
Copy link
Contributor

@Freed-Wu Freed-Wu commented Mar 30, 2022

Fix #1530

@mwaskom
Copy link
Owner

mwaskom commented Mar 31, 2022

Please put this file in the external/ directory with other vendored packages and include a copy of its license in the licenses/ directory. And please fill out the PR description to link to previous discussions and close related issues.

@Freed-Wu
Copy link
Contributor Author

Fix #1530

@mwaskom
Copy link
Owner

mwaskom commented Apr 3, 2022

Thanks @Freed-Wu , you need to put the "closes #issue" in the first post otherwise it won't link properly. I edited the PR description to do that.

@codecov
Copy link

codecov bot commented Apr 3, 2022

Codecov Report

Merging #2773 (47b5c8a) into master (069d53a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2773   +/-   ##
=======================================
  Coverage   97.53%   97.53%           
=======================================
  Files          17       17           
  Lines        6439     6440    +1     
=======================================
+ Hits         6280     6281    +1     
  Misses        159      159           
Impacted Files Coverage Δ
seaborn/utils.py 95.22% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 069d53a...47b5c8a. Read the comment docs.

@mwaskom mwaskom merged commit 47b5c8a into mwaskom:master Apr 3, 2022
@mwaskom
Copy link
Owner

mwaskom commented Apr 3, 2022

Thanks @Freed-Wu, I did a little fixup and then merged locally. In the future, please

  • Make changes on a branch, rather than on your version of master
  • Take a moment to look at the context around the change you are making for opening the PR; I had to fix the docstring to the get_data_home function that you edited, which had a reference to the previous cache location.

@Freed-Wu
Copy link
Contributor Author

Freed-Wu commented Apr 3, 2022

Thanks!

@mxsrc
Copy link

mxsrc commented Apr 3, 2022

Thanks for this PR @Freed-Wu !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change load_dataset cache dir default
3 participants