Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default FacetGrid titles on initialization instead of after plotting #2705

Merged
merged 3 commits into from
Nov 27, 2021

Conversation

Denbergvanthijs
Copy link
Contributor

@Denbergvanthijs Denbergvanthijs commented Nov 27, 2021

Lets see if any tests will fail. It passed thru tests and linting on my own machine.

Fixes #2702

@codecov
Copy link

codecov bot commented Nov 27, 2021

Codecov Report

Merging #2705 (8f9d2fb) into master (d4aa367) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 8f9d2fb differs from pull request most recent head bfcf8c9. Consider uploading reports for the commit bfcf8c9 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2705   +/-   ##
=======================================
  Coverage   97.53%   97.53%           
=======================================
  Files          17       17           
  Lines        6439     6439           
=======================================
  Hits         6280     6280           
  Misses        159      159           
Impacted Files Coverage Δ
seaborn/axisgrid.py 96.07% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4aa367...bfcf8c9. Read the comment docs.

@mwaskom
Copy link
Owner

mwaskom commented Nov 27, 2021

This looks good. Can you add an entry in the release notes?

@Denbergvanthijs
Copy link
Contributor Author

Added! Feel free to change the text, English is not my native language. Thank you very much for the fast responses!

@mwaskom mwaskom changed the title Possible fix for #2702 Add default FacetGrid titles on initialization instead of after plotting Nov 27, 2021
@mwaskom
Copy link
Owner

mwaskom commented Nov 27, 2021

Perfect. Thanks!

@mwaskom mwaskom merged commit 9425588 into mwaskom:master Nov 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: FacetGrid.set_titles() does not work if FacetGrid.map() is called afterwards
2 participants