Fix box(en)plot colour tests #2693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As was noted in mwaskom#2663 (comment), the `test_box_colors` tests are broken because `zip` only iterates to the shortest input. For boxplot, there are in fact 3 copies of the palette not 2. For boxenplot, it doesn't add `Patch` at all but `PatchCollection`, as can be seen in the related tests.
Codecov Report
@@ Coverage Diff @@
## master #2693 +/- ##
=======================================
Coverage 97.53% 97.53%
=======================================
Files 17 17
Lines 6439 6439
=======================================
Hits 6280 6280
Misses 159 159 Continue to review full report at Codecov.
|
|
Thanks @QuLogic, I think I determined that the short-circuit zip was actually intentional, or fine at least, since it was excluding the artists that get added to support the legend. But this makes it more clean. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As was noted in #2663 (comment), the
test_box_colorstests are broken becauseziponly iterates to the shortest input.For
boxplot, there are in fact 3 copies of the palette not 2 for the second test.For
boxenplot, it doesn't addPatchat all butPatchCollection, as can be seen in the related tests.