Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error from bivariate displot with common_bins=False #2640

Merged
merged 2 commits into from
Aug 14, 2021
Merged

Fix error from bivariate displot with common_bins=False #2640

merged 2 commits into from
Aug 14, 2021

Conversation

mwaskom
Copy link
Owner

@mwaskom mwaskom commented Aug 13, 2021

Fixes #2638

@mwaskom mwaskom added this to the v0.11.2 milestone Aug 13, 2021
@mwaskom mwaskom mentioned this pull request Aug 13, 2021
Closed
@codecov
Copy link

codecov bot commented Aug 13, 2021 •
edited
Loading

Codecov Report

Merging #2640 (2731bb1) into master (bfb7a04) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2640   +/-   ##
=======================================
  Coverage   97.43%   97.43%           
=======================================
  Files          17       17           
  Lines        6405     6405           
=======================================
  Hits         6241     6241           
  Misses        164      164
Impacted Files Coverage Δ
seaborn/distributions.py 96.40% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfb7a04...2731bb1. Read the comment docs.

@mwaskom mwaskom merged commit 473ebef into master Aug 14, 2021
@mwaskom mwaskom deleted the fix_histplot_2d_colornorm branch August 14, 2021 20:35
mwaskom added a commit that referenced this pull request Aug 14, 2021
@mwaskom
Fix error from bivariate displot with common_bins=False (#2640)
f8de332 
* Fix error from bivariate displot with common_bins=False

Fixes #2638

* Update release notes

(cherry picked from commit 473ebef)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix mod:distributions
Projects
None yet
Milestone
v0.11.2
Development

Successfully merging this pull request may close these issues.

Bivariate displot and various bin size does not work in 2D
1 participant
@mwaskom