Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve FacetGrid axis labeling #2583

Merged
merged 4 commits into from
May 13, 2021
Merged

Improve FacetGrid axis labeling #2583

merged 4 commits into from
May 13, 2021

Conversation

mwaskom
Copy link
Owner

@mwaskom mwaskom commented May 12, 2021

A few small changes to make custom FacetGrid plotting a little easier:

@mwaskom mwaskom added this to the v0.12.0 milestone May 12, 2021
@codecov
Copy link

codecov bot commented May 12, 2021 •
edited
Loading

Codecov Report

Merging #2583 (0aa12e4) into master (f884505) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 0aa12e4 differs from pull request most recent head 9c2475d. Consider uploading reports for the commit 9c2475d to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2583      +/-   ##
==========================================
- Coverage   97.45%   97.44%   -0.01%     
==========================================
  Files          17       17              
  Lines        6354     6350       -4     
==========================================
- Hits         6192     6188       -4     
  Misses        162      162
Impacted Files Coverage Δ
seaborn/axisgrid.py 95.63% <100.00%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f884505...9c2475d. Read the comment docs.

@mwaskom mwaskom merged commit 58461e1 into master May 13, 2021
@mwaskom mwaskom deleted the improve_facetgrid_labels branch May 13, 2021 12:14
@mwaskom mwaskom mentioned this pull request Jul 22, 2021
Merged
3 tasks
@mwaskom mwaskom modified the milestones: v0.12.0, v0.11.2 Aug 6, 2021
mwaskom added a commit that referenced this pull request Aug 6, 2021
@mwaskom
Improve FacetGrid axis labeling (#2583)
87aa6d7 
* Use keyword arguments in map_dataframe to label axes

* Disable interior axis label visibility instead of removing labels

* Update release notes and docs

* Fix typo [skip ci]

(cherry picked from commit 58461e1)
@mwaskom mwaskom mentioned this pull request Aug 8, 2021
Closed
mwaskom added a commit that referenced this pull request Aug 8, 2021
@mwaskom
Fix non-removed interior axis labels and diagonal legends in PairGrid
93b3bd1 
These were oversights from #2583
@mwaskom mwaskom mentioned this pull request Aug 8, 2021
Merged
mwaskom added a commit that referenced this pull request Aug 8, 2021
@mwaskom
Fix non-removed interior axis labels and diagonal legends in PairGrid (…
bfb7a04 
…#2637)

These were oversights from #2583
mwaskom added a commit that referenced this pull request Aug 8, 2021
@mwaskom
Fix non-removed interior axis labels and diagonal legends in PairGrid (…
be65400 
…#2637)

These were oversights from #2583

(cherry picked from commit bfb7a04)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement mod:axisgrid
Projects
None yet
Milestone
v0.11.2
Development

Successfully merging this pull request may close these issues.

Disable visibility of interior axis labels in FacetGrid [BUG] map_dataframe removes axis labels
1 participant
@mwaskom