Avoid error from relplot faceting variable name collision #2581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwaskom
force-pushed
the
fix_relplot_variable_collision
branch
from
8693331 to
ead08dc
Compare
Codecov Report
@@ Coverage Diff @@
## master #2581 +/- ##
=======================================
Coverage 97.44% 97.45%
=======================================
Files 17 17
Lines 6351 6354 +3
=======================================
+ Hits 6189 6192 +3
Misses 162 162
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2488
This is a short-term fix and, as mentioned in the original issue, there will hopefully be better overall integration between the plotter objects and the figure-level functions such that the complicated operations that caused (and then fixed) the bug are no longer necessary. But it is a relatively easy fix so might as well put it in for now.