Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set heatmap yticklabel alignment while rotating #2574

Merged
merged 2 commits into from
May 6, 2021

Conversation

mwaskom
Copy link
Owner

@mwaskom mwaskom commented May 5, 2021

Closes #2484

With the case from that issue:

m = ['January', 'February', 'March']
sns.heatmap(data=np.random.rand(3, 3), yticklabels=m, xticklabels=m)

image

Not sure of a good way to test this that isn't just asserting that the thing that's in the code happens, so I'm not adding a test. Should hopefully be able to catch it in the docs if it reappears.

@mwaskom mwaskom added this to the v0.12.0 milestone May 5, 2021
@codecov
Copy link

codecov bot commented May 5, 2021

Codecov Report

Merging #2574 (8aab749) into master (4f79753) will increase coverage by 0.18%.
The diff coverage is 100.00%.

❗ Current head 8aab749 differs from pull request most recent head ec6454a. Consider uploading reports for the commit ec6454a to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2574      +/-   ##
==========================================
+ Coverage   97.27%   97.46%   +0.18%     
==========================================
  Files          17       17              
  Lines        6340     6341       +1     
==========================================
+ Hits         6167     6180      +13     
+ Misses        173      161      -12     
Impacted Files Coverage Δ
seaborn/rcmod.py 100.00% <ø> (ø)
seaborn/matrix.py 95.87% <100.00%> (+<0.01%) ⬆️
seaborn/categorical.py 98.54% <0.00%> (+0.14%) ⬆️
seaborn/distributions.py 96.37% <0.00%> (+0.32%) ⬆️
seaborn/regression.py 97.79% <0.00%> (+0.62%) ⬆️
seaborn/_docstrings.py 100.00% <0.00%> (+12.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a41703e...ec6454a. Read the comment docs.

@mwaskom mwaskom merged commit 430c1bf into master May 6, 2021
@mwaskom mwaskom deleted the heatmap_yticklabel_alightment branch May 6, 2021 00:09
@mwaskom mwaskom modified the milestones: v0.12.0, v0.11.2 Aug 6, 2021
mwaskom added a commit that referenced this pull request Aug 6, 2021
* Set heatmap yticklabel alignment while rotating

Closes #2484

* Update release notes [skip ci]

(cherry picked from commit 430c1bf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default alignment y tick labels of sns.heatmap
1 participant