Create example_thumbs while running conf.py #2572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a little hacky, but including the thumbnail images in the build seems otherwise complicated because they are written into raw html source with an <img> tag, not using the sphinx image directive. Fixes #2532
Codecov Report
@@ Coverage Diff @@
## master #2572 +/- ##
=======================================
Coverage 97.45% 97.46%
=======================================
Files 17 17
Lines 6332 6340 +8
=======================================
+ Hits 6171 6179 +8
Misses 161 161
Continue to review full report at Codecov.
|
mwaskom
added a commit
that referenced
this pull request
Jun 18, 2021
As an alternative to creating the directory in conf.py Cf #2572
mwaskom
added a commit
that referenced
this pull request
Jun 18, 2021
As an alternative to creating the directory in conf.py Cf #2572
mwaskom
added a commit
that referenced
this pull request
Jun 19, 2021
As an alternative to creating the directory in conf.py Cf #2572
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a little hacky, but including the thumbnail images in the build seems otherwise complicated because they are written into raw html source with an
<img>tag, not using the sphinx image directive.Fixes #2532