Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable autolayout rcparam when constructing Facet/PairGrid #2571

Merged
merged 2 commits into from
May 5, 2021

Conversation

mwaskom
Copy link
Owner

@mwaskom mwaskom commented May 5, 2021

This prevents matplotlib from doing a naive tight_layout operation that ignores the space the legend needs to occupy.

Closes #2496

@codecov
Copy link

codecov bot commented May 5, 2021

Codecov Report

Merging #2571 (f2b0298) into master (ec8fcc9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head f2b0298 differs from pull request most recent head f5c04ad. Consider uploading reports for the commit f5c04ad to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2571   +/-   ##
=======================================
  Coverage   97.45%   97.46%           
=======================================
  Files          17       17           
  Lines        6332     6340    +8     
=======================================
+ Hits         6171     6179    +8     
  Misses        161      161           
Impacted Files Coverage Δ
seaborn/_statistics.py 100.00% <100.00%> (ø)
seaborn/axisgrid.py 95.65% <100.00%> (+0.01%) ⬆️
seaborn/distributions.py 96.37% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09f5746...f5c04ad. Read the comment docs.

@mwaskom mwaskom merged commit afe5635 into master May 5, 2021
@mwaskom mwaskom deleted the disable_autolayout branch May 5, 2021 14:40
@mwaskom mwaskom added this to the v0.11.2 milestone Aug 6, 2021
mwaskom added a commit that referenced this pull request Aug 6, 2021
* Disable autolayout rcparam when constructing Facet/PairGrid

Closes #2496

* Update release notes [skip ci]

(cherry picked from commit afe5635)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

figure.autolayout rc param interferes with FacetGrid legend position
1 participant