Replace version numbering interface #2485
Conversation
As the distutils.version is depecrating, it was replaced with the packaging.version. In order to give support for all version numbering, according to PEP 440, parse was used.
Codecov Report
@@ Coverage Diff @@
## master #2485 +/- ##
==========================================
- Coverage 97.45% 97.21% -0.24%
==========================================
Files 17 17
Lines 6317 6317
==========================================
- Hits 6156 6141 -15
- Misses 161 176 +15
Continue to review full report at Codecov.
|
|
Thanks! I guess |
Added the packaging dependency to install_requires field in setup.py.
setup.py
Outdated
| @@ -33,6 +33,7 @@ | |||
| 'numpy>=1.16', | |||
| 'pandas>=0.24', | |||
| 'matplotlib>=3.0', | |||
| 'packaging>=29.0', | |||
There was a problem hiding this comment.
(I am mostly asking if you have a link/reference to support the choice ... I don't know the right answer here).
There was a problem hiding this comment.
I was testing with the most recent packaging version. I am going to make some tests to evaluate if it can be used with previous versions.
There was a problem hiding this comment.
I would expect the parse behavior to be highly stable across versions of packaging; I'm not sure it will be necessary to specify a minimum version.
Correcting the wrong version number of the packaging dependency.
|
Note that pandas decided to vendor the |
|
Superseded and closed by #2659 |
As the
distutils.versionis deprecating, it was replacedwith the
packaging.version. In order to give support for allversion numbering, according to PEP 440, parse was used.
Fixes #2466