Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor semantic mapping operations #2090

Merged
merged 48 commits into from
May 23, 2020
Merged

Refactor semantic mapping operations #2090

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
e90067f
Prototype of rugplot that passes original tests
mwaskom May 19, 2020
4b145aa
Update test style
mwaskom May 19, 2020
872a103
Implement idea for less-verbose interaction with Plotter classes
mwaskom May 19, 2020
3838f69
Explore an idea about how to abstract hue mapping
mwaskom May 20, 2020
8a31b95
Shush Flake8
mwaskom May 20, 2020
8ff1f9c
Define semantics with tuples, not lists, to make immutable
mwaskom May 20, 2020
8f29936
Define semantic mappings with some complex higher-order magic
mwaskom May 20, 2020
44dbf88
Move some of the hue mapping logic
mwaskom May 20, 2020
0dc1333
Continued refactoring of variable assignment and hue mapping
mwaskom May 20, 2020
aa05d14
Refactor lineplot and get tests to pass
mwaskom May 21, 2020
7f9a15f
Get most RelationalPlotter tests passing
mwaskom May 21, 2020
9758ff3
Fix error introduced during refactoring
mwaskom May 21, 2020
dddc857
Move hue mapping tests from test_relational to test_core
mwaskom May 21, 2020
45a1b5f
Avoid treating string palette arg as signaling categorical
mwaskom May 21, 2020
9730248
Set map_type to include datetime, add note about missing implementation
mwaskom May 21, 2020
eb8b390
Change semantic inheritance to be restrictive rather than expansive
mwaskom May 21, 2020
e191856
Consider boolean data categorical at Plotter level
mwaskom May 21, 2020
2756efb
Sort out where utils/core funcs should go
mwaskom May 21, 2020
b240c38
Strip nose out of the utils tests
mwaskom May 21, 2020
b39b89c
Move new decorator to where it belongs and add a test
mwaskom May 21, 2020
771b807
Clean up a few leftovers from utils reorg
mwaskom May 21, 2020
bd8b00d
Add more HueMapping tests
mwaskom May 21, 2020
8a41017
Make core module private
mwaskom May 21, 2020
97bc4e5
Make objects in core non-private
mwaskom May 21, 2020
79116ed
Add initial version of SizeMapping object
mwaskom May 21, 2020
0df8593
Messy first pass at replacing parse_size with SizeMapping
mwaskom May 21, 2020
1183736
Fix size mapping to match current behavior, defer decoupling from plo…
mwaskom May 22, 2020
3a34532
Add test to capture relplot bug
mwaskom May 22, 2020
8f99541
Fix relplot numeric hues
mwaskom May 22, 2020
f1ae674
Move all hue/size lookup logic into corresponding Mapping objects
mwaskom May 22, 2020
303628f
Finalize refactoring of size mapping
mwaskom May 22, 2020
ce66b38
Add prototype of StyleMapping
mwaskom May 22, 2020
42026af
Integrate StyleMapping into relational plots
mwaskom May 22, 2020
5d80109
Get relational tests to pass
mwaskom May 22, 2020
00fc9bb
Move StyleMapping tests to core and excise parse_style from relational
mwaskom May 22, 2020
5ab9a63
Point rugplot at old code for now
mwaskom May 22, 2020
e1d6e5f
Add some more basic tests
mwaskom May 22, 2020
baf0524
Treat units as a normal semantic
mwaskom May 22, 2020
d75789d
Rename assign_variables method
mwaskom May 23, 2020
2aaef33
Address some TODOs about style/organization/defaults
mwaskom May 23, 2020
35e4457
Address more small TODOs and flesh out docs
mwaskom May 23, 2020
feae13b
LogNorm now fails with non-positive data (as it arguably should)
mwaskom May 23, 2020
266157b
Handle units in relplot (fixes #2080)
mwaskom May 23, 2020
5c0de8a
Ignore false-alarm warning from numpy on string/number comparison
mwaskom May 23, 2020
12b4d28
Catch a few pieces of residual cruft
mwaskom May 23, 2020
2d5a0bd
Ignore a separate dubious numpy warning
mwaskom May 23, 2020
1d88a50
Improve test coverage
mwaskom May 23, 2020
ddad631
Avoid error in relational user guide page
mwaskom May 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion doc/tutorial/relational.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,7 +459,8 @@
"sns.relplot(x=\"time\", y=\"firing_rate\",\n",
" hue=\"coherence\", style=\"choice\",\n",
" hue_norm=LogNorm(),\n",
" kind=\"line\", data=dots);"
" kind=\"line\",\n",
" data=dots.query(\"coherence > 0\"));"
]
},
{
Expand Down
1 change: 1 addition & 0 deletions pytest.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@ filterwarnings =
; Warnings raised from within pytest itself
ignore:Using or importing the ABCs:DeprecationWarning
ignore:the imp module is deprecated in favour of importlib
junit_family=xunit1
Loading