-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Edge color with catplot
with kind=bar
#3542
Labels
Milestone
Comments
Can you provide a full reproducible example using one of the sample datasets? Thanks! |
The default example shows this:
I see that this works as intended in 0.12.2 but not in 0.13.0. |
mwaskom
added a commit
that referenced
this issue
Nov 4, 2023
mwaskom
added a commit
that referenced
this issue
Nov 4, 2023
* Fix edgecolor in catplot with kind='bar' Fixes #3542 * Use rule-based default edgecolor closer to where it is defined
Awesome! Thank you for fixing it! |
mwaskom
added a commit
that referenced
this issue
Nov 4, 2023
* Fix edgecolor in catplot with kind='bar' Fixes #3542 * Use rule-based default edgecolor closer to where it is defined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello,
When passing
edgecolor
to catplot for a bar, the argument doesn't reach the underlyingp.plot_bars
to generate the required output.Currently there is a line
edgecolor = p._complement_color(kwargs.pop("edgecolor", default), color, p._hue_map)
is not passed into the block
elif kind=="bar"
. A local "hack" I implemented is to add akwargs["edgecolor"] = edgecolor
beforep.plot_bars
call. Let me know if I should provide more details.This is on version
0.13.0
.The text was updated successfully, but these errors were encountered: