Initialize default semantics with relevant variable names

mwaskom · Oct 16, 2021 · 42020a0 · 42020a0
1 parent c7777d9
commit 42020a0
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/.gitignore b/.gitignore
@@ -12,3 +12,4 @@ htmlcov/
 .vscode/
 .pytest_cache/
 notes/
+notebooks/
diff --git a/seaborn/_core/plot.py b/seaborn/_core/plot.py
@@ -50,11 +50,11 @@
 
 SEMANTICS = {  # TODO should this be pluggable?
     "color": ColorSemantic(),
-    "facecolor": ColorSemantic(),
-    "edgecolor": ColorSemantic(),
+    "facecolor": ColorSemantic(variable="facecolor"),
+    "edgecolor": ColorSemantic(variable="edgecolor"),
     "marker": MarkerSemantic(),
     "linestyle": LineStyleSemantic(),
-    "fill": BooleanSemantic(),
+    "fill": BooleanSemantic(variable="fill"),
     "linewidth": LineWidthSemantic(),
 }
 

diff --git a/seaborn/_core/scales.py b/seaborn/_core/scales.py
@@ -35,6 +35,13 @@ def __init__(
         self.type_declared = True
 
         if norm is None:
+            # TODO customize norm_from_scale to return "datetime scale" etc.?
+            # TODO also we could use a pre-norm function for have a map_pointsize
+            # that has the option of squaring the sizes before normalizing.
+            # From the scale perspective it would be a general pre-norm function,
+            # but then map_pointsize could have a special param.
+            # TODO what else is this useful for? Maybe outlier removal?
+            # Maybe log norming for color?
             norm = norm_from_scale(scale, norm)
         self.norm = norm