Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various EAV enhancements/refactoring #1

Closed
wants to merge 5 commits into from
Closed

Various EAV enhancements/refactoring #1

wants to merge 5 commits into from

Conversation

thedavidmccann
Copy link
Contributor

Here's a summary of the following commits:

  • expand_filter_string is iterative now, not recursive. Hopefully obviates a little of Gelvin's beautiful magic that was at work (and is still largely intact in this new realization of the function)
  • I allowed other, non-entity classes to take advantage of magic filter expansion, by user of EavRegistry.register(MyNonEntityClass, manager_only=True)
  • QPFM: filter() and exclude() now alter Q arguments in-place to expand strings and restructure the Q tree as necessary

NOTE: I've yet to update the test cases, I wanted to get these changes out to everyone for review. Any help in this area would be helpful, as I've only done limited shell-testing on this new functionality.

If any of these commits are controversial you can always pull in a subset (or none)!

@ksamuel
Copy link

ksamuel commented Sep 14, 2010

Cool, but maybe not on master yet. Let's pull that in dev. Not supposed to work on that immediately, will ask matt if I can.

@dgelvin
Copy link
Contributor

dgelvin commented Sep 16, 2010

Pulled into dev

philipn referenced this pull request in philipn/django-eav Sep 13, 2012
ahmedOpeyemi referenced this pull request in eHealthAfrica/django-eav Nov 4, 2016
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants