issue:#14 replaceAll addition #15
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvondracek
requested changes
Feb 11, 2023
| code: '$("div").append($("input").replaceAll("<script>"))', | ||
| errors: [{message: error, type: 'CallExpression'}] | ||
| } | ||
| ] |
There was a problem hiding this comment.
replaceAll method is different than than the rest of unsafe methods. Calee and parameter are reversed, see https://api.jquery.com/replaceAll/.
$( "<script>" ).replaceAll( "div" );In order to better understand this, try to create XSS-vulnerable code with replaceAll.
- Please fix these tests based on https://api.jquery.com/replaceAll
There was a problem hiding this comment.
Ohh alright, will check more on this and update accordingly.
|
Please be aware that changes are commited by @aishwarya-nagtilak08 account while the fork is owned by @sameer-555. Is this intentional? |
|
Closes #14 after merge. |
2 tasks
|
This might be related to mvondracek/jQuery-XSS#7 in case you would like to look into that as well. |
|
That wasn't intentional but expected since I was using my girlfriend's laptop. |
|
mvondracek/jQuery-XSS#7 I'll look into it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team,
this is fix for issue #14, this is one of my first opensource contributions. please let know in case there are any corrections.