Skip to content

Commit

Permalink
workflow: ensure "make test" builds externals and use in workflow
Browse files Browse the repository at this point in the history
This commit ensures that externals are build during the tests and
that the GH action will test with externals too.

This is slightly hacky as it requires the network. Eventually we
can pull in externals via build-deps or vendor them but for now
this unblocks the otk work.
  • Loading branch information
mvo5 committed Sep 9, 2024
1 parent f921057 commit 1470edb
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
python -m pip install --upgrade pip
pip install .[dev]
- name: Run unit tests
run: PYTHONPATH=./src pytest
run: PYTHONPATH=./src make test
- name: Validate OTK configuration
run: |
for f in example/*/*.yaml; do
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ format:
@find src test -name '*.py' | xargs autopep8 --in-place

.PHONY: test
test:
test: external
@pytest

.PHONY: push-check
Expand Down

0 comments on commit 1470edb

Please sign in to comment.