feat: apply line highlight only on focused buffer #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default value set to false, if this key set to true, autocmds will be added to the augroup to set cursorline state, which is will enable line higlight only on focused buffer.
This autocmds is added when the `config.focus_only` set to true, the default is false.
The use case:
I opened 2 buffers, in the current focus buffer, I entered the
`visual` mode, and then jump to the next buffer, the next buffer
has `visual` mode line highlight even tough I am in `normal` mode
Adding `WinLeave` fixed that scenario.
|
There is still an issue with telescope prompt (or maybe any other prompt that have input prompt), i think it will be better if we can disable
|
|
I think less options is better. Ideally the coloured cursorline would only be on focused buffer Edit: After seeing how this option changes the cursorline setting it may be best to have it opt-in. If you agree I'll merge how it is now |
|
I think so, you can merge it if you happy with the current implementation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option enabled by passing
focus_only = trueto the options, the default is set to false, or do you think it is better to enabled by default ?