Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add visual block-wise mode #25

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

fitrh
Copy link
Collaborator

@fitrh fitrh commented Apr 27, 2022

I made this PR because I don't know if the block-wise visual mode (Ctrl+v) was intentionally ignored or forgotten, if it was intentional, feel free to close it.

@fitrh
Copy link
Collaborator Author

fitrh commented Apr 27, 2022

It seem github diff does not render the Ctrl+v characters, here's the diff

20220428_051148_full

@mvllow
Copy link
Owner

mvllow commented Apr 28, 2022

Thank you for adding this 😌

Your diff image shows ^V on both line 201 and 206 but copying this locally, I only see ^V on line 206, whereas 201 is an empty string

@fitrh
Copy link
Collaborator Author

fitrh commented Apr 29, 2022

Yes, copy-paste from github diff doesn't give correct characters, it should be cloned

@mvllow mvllow merged commit e8862e6 into mvllow:main Apr 29, 2022
@mvllow
Copy link
Owner

mvllow commented Apr 29, 2022

Wish there was a better way to get the ^V modes that rendered properly everywhere – I could see that being confusing for contributors viewing the code on GitHub. I was unable to find any other way though so this is good 💜

@fitrh
Copy link
Collaborator Author

fitrh commented Apr 29, 2022

As I can recall, it's something called control character

@fitrh
Copy link
Collaborator Author

fitrh commented Apr 29, 2022

Found it, :help i_CTRL-V

@fitrh fitrh deleted the feat/handle-vblock-mode branch April 29, 2022 16:26
@mvllow
Copy link
Owner

mvllow commented Apr 29, 2022

This does seem to work via nvim_replace_termcodes('<C-V>', true, true, true) 🎉

mvllow added a commit that referenced this pull request Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants