Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enabled multiple metrics per ref #934

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Conversation

calmez
Copy link

@calmez calmez commented Oct 28, 2024

Context

We have pipelines running on the same git ref but with different settings in variables.
Before this change here we had the problem that we were missing metrics for some of these runs.

What changed

We generalized how pipelines are cached using the Store instead of the LastPipeline on the Ref object.
Furthermore, we used variables (if configured) for deciding if a new metric needs to be created or not.

We have tried this approach and can confirm that this now solves the issue we had before.

Backwards compatibility

The new behavior is backwards compatible. In the pipelines section of a pull section in the config there's a new key per_ref that you can use to set how many most recent pipelines you want to fetch per ref. The default is set to 1 which should result in the same behavior as before this change. That means that existing users will not be affected by this and have to actively configure this behavior.

@calmez calmez changed the title enabled multiiple metrics per ref feat: enabled multiiple metrics per ref Oct 28, 2024
@calmez calmez changed the title feat: enabled multiiple metrics per ref feat: enabled multiple metrics per ref Nov 6, 2024
@calmez
Copy link
Author

calmez commented Jan 21, 2025

@mvisonneau Any chance we can get this up in mainline?
We're using this already in our deployment and it seems quite stable and certainly very useful for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant