E621 tag warning bounty #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdicarlo
reviewed
Jan 24, 2025
|
|
||
| if (generalTags < 10) { | ||
| warnings.push( | ||
| `It is recommended to add atleast 10 general tags ( ${generalTags} / 10 ). See https://e621.net/help/tagging_checklist`, |
mvdicarlo
reviewed
Jan 24, 2025
|
|
||
| private async getMetdata<T>(url: string) { | ||
| // TODO Maybe replace with fetch for better performance | ||
| // TODO Maybe use caching? |
There was a problem hiding this comment.
caching would probably be the better option to improve performance, and reduce http calls to e621 in general. dry validations might get spammy if lots of changes are being made.
leaftail1880
commented
Jan 25, 2025
|
@mvdicarlo fixed all the issues |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/leaftail1880/postybirb-plus/releases/tag/v3.1.54