Fix Bsky login check #382
Merged
Fix Bsky login check #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It accessed undefined data and fell on its face, now it returns successfully with loggedIn set to false.
After rebasing to the main repository's develop branch, Bluesky login in the UI is suddenly failing with some kind of garbage "url must be a string not an object" error when we aren't passing any such parameter in the first place. I don't know what that's about, but doing it in electron-app works fine, so I changed the UI code to defer to that instead. This also improves the error messages so that the user isn't left with the page seemingly not reacting to their input at all.
App passwords have a pretty regular format, so we can check for that and warn the user that they enter something else, probably their account password. Since the app password format could conceivably change in the future, we leave it at a warning and don't refuse saving in that case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bsky login checks started failing in strange ways with inexplicable error messages deep inside the atproto library. For some reason this only happens inside the ui component and only on a fresh instance of PostyBirb, so I dunno what that's about. Moving the login check to the electron-app seems to fix it though, so this removes atproto from the ui component and goes that route instead.
This also fixes the Bsky login check spewing errors when no credentials are present and warns the user if the password they enter doesn't look like an app password, since they are likely to enter their account password instead, which causes exciting behavior if they have 2FA enabled and won't actually work.