Use letter and number classes in tag replacements #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For Mastodon-alikes, Misskey, Bluesky and Twitter. Instead of replacing all non-English letters and non-Arabic digits with nothing and causing those tags to disappear, they now use proper Unicode character classes for letters and numbers that will allow other scripts through while still replacing punctuation and whatnot.
mvdicarlo
reviewed
Nov 5, 2024
| @@ -182,7 +182,9 @@ export class Bluesky extends Website { | |||
|
|
|||
| formatTags(tags: string[]) { | |||
| return this.parseTags( | |||
| tags.map(tag => tag.replace(/[^a-z0-9]/gi, ' ')).map(tag => tag.split(' ').join('')), | |||
| tags | |||
| .map(tag => tag.replace(/[^\p{Letter}\p{Number}]/giu, ' ')) | |||
There was a problem hiding this comment.
q: is this a newer js feature? (and by newer I mean anything after 2018 since I haven't been able to keep up with all the new specs)
There was a problem hiding this comment.
Uh, I didn't check, Perl had this since 2000 so I'd assumed that everyone that copied their regular expressions from there had it too. Looking it up, apparently it was introduced into JavaScript in 2015, so I guess they were 15 years late to the party, but still have had it for a while now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Mastodon-alikes, Misskey, Bluesky and Twitter. Instead of replacing all non-English letters and non-Arabic digits with nothing and causing those tags to disappear, they now use proper Unicode character classes for letters and numbers that will allow other scripts through while still replacing punctuation and whatnot.