add preliminary support for generic code #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, the fix isn't actually complete, as there's also IndexExpr. Will send a second version. |
|
Reported the panics when running on std at golang/go#53604. |
|
Now with Go 1.17 support. The fix was indeed not trivial :) |
Note that we don't yet support reporting unused parameters on generic functions, as showed by the TODO in typeparams.txt, but at least we don't panic as quickly as before. Also note that running unparam on std currently panics as well, presumably due to a bug in go/ssa that I will report shortly. Thanks to Ainar Garipov for reporting and Ludovic Fernandez for suggesting a fix. Note that we need to use x/exp/typeparams to keep support for Go 1.17.x. Fixes #62.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(see commit message)
Fixes #62.