syntax: fix two bugs when formatting case clauses #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we remove any newlines when printing, don't insert others later on in the source. While here, improve how we keep track of p.line throughout the printer. Fixes #779.
We weren't doing that when a case clause item used quoted strings, due to the `p.tok == _LitWord` condition that shouldn't be there. Add tests, docs, and also prevent SingleLine from producing bad syntax when printing the new test. Fixes #917.
|
Want. But I am only using the binary. I will try to build me a small Docker with it for testing. |
|
Beautiful. I can confirm this branch works as expected for me. Tested with the ➜ shfmt -d -i 2 -ci test.sh
--- test.sh.orig
+++ test.sh
@@ -3,8 +3,7 @@
action=download
case $action in
- -*)
- ;;
+ -*) ;;
upload)
# This upload section is being messed up with a weird backslash |
DannyBen
added a commit
to DannyBen/bashly
that referenced
this pull request
Dec 3, 2022
|
I can confirm that the issue with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(see commit messages - please do not squash)
Fixes #779.
Fixes #917.
cc @ainar-g @Julien-Elie @zx8 @DannyBen if you want to test this out