Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syntax: fix whitespace on nested subshells #874

Merged
merged 1 commit into from
Jun 6, 2022

Conversation

riacataquian
Copy link
Collaborator

we want white space on nested subshells if its in a single line since
its ambiguous, eg we want ( ( over ((

this shouldn't be the case for multiple lines- fix the logic that adds
white space to only do so if the two subshells are in the same line

fixes #814

@riacataquian riacataquian requested a review from mvdan June 6, 2022 13:23
we want white space on nested subshells if its in a single line since
its ambiguous, eg we want `( (` over `((`

this shouldn't be the case for multiple lines- fix the logic that adds
white space to only do so if the two subshells are in the same line

fixes mvdan#814
@riacataquian riacataquian enabled auto-merge (squash) June 6, 2022 13:25
Copy link
Owner

@mvdan mvdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is re-landing #869 as we merged it wrong.

@riacataquian riacataquian merged commit bd03166 into mvdan:master Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

syntax: trailing white space added after opening parenthesis '('
2 participants