lexer: allow extglob wildcards as function names #771
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the lexer assumes an extglob token if any of the wildcards expressions
(such as
@
, and+
) are succeeded by a left parenthesis but thatproves to be an issue if the wildcard is used as a function name.
example input:
bash
andgosh
comparison:given
in.sh
, gosh reports about a syntax error - this is becausea closing bracket is found while the lexer isn't assuming a function
block
fix the issue by assuming a function if one of the conditions below is
true:
preceded by a "function"
(
is immediately succeeded by a)
- although this is a validbash syntax, we'll operate on the likelihood that it is a function
fixes #739