-
-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
interp: panics on extglob nodes #841
Comments
FYI this is bash's extglob, which you can find in its man page; we don't support zsh yet. The interpreter doesn't support expanding that syntax, simply because this feature is very rarely used, so it's not been a priority. I guess we could make the interpreter error instead of panic, though - would that help? I would happily approve and merge a PR doing that, as I agree that having the interpreter panic over a known TODO is a bit dramatic. |
For the sake of clarity, I'd be happy to review a PR implementing this change with tests, if anyone feels like taking a stab. |
we currently don't support bash's `extglob` option and when attempted, interp panics fix expand so that we return the error properly and exit with status `1` fixes mvdan#841
we currently don't support bash's `extglob` option and when attempted, interp panics fix expand so that we return the error properly and exit with status `1` fixes #841
*(/)
is zsh for "* but only for directories". Which it is of course fine if gosh doesn't handle, but it shouldn't panic, I wouldn't think.The text was updated successfully, but these errors were encountered: