interp: trace should write to stderr by default

Fixes #926.
mvdan · Oct 16, 2022 · c780bb4 · c780bb4
1 parent 13def01
commit c780bb4
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/interp/interp_test.go b/interp/interp_test.go
@@ -3130,6 +3130,14 @@ single quote
 	// for trace
 	{
 		`set -x
+exec >/dev/null
+echo "trace should go to stderr"`,
+		`+ exec
++ echo 'trace should go to stderr'
+`,
+	},
+	{
+		`set -x
 animals=(dog, cat, otter)
 for i in ${animals[@]}
 do

diff --git a/interp/trace.go b/interp/trace.go
@@ -14,7 +14,7 @@ import (
 type tracer struct {
 	buf       bytes.Buffer
 	printer   *syntax.Printer
-	stdout    io.Writer
+	output    io.Writer
 	needsPlus bool
 }
 
@@ -25,7 +25,7 @@ func (r *Runner) tracer() *tracer {
 
 	return &tracer{
 		printer:   syntax.NewPrinter(),
-		stdout:    r.stdout,
+		output:    r.stderr,
 		needsPlus: true,
 	}
 }
@@ -74,7 +74,7 @@ func (t *tracer) flush() {
 		return
 	}
 
-	t.stdout.Write(t.buf.Bytes())
+	t.output.Write(t.buf.Bytes())
 	t.buf.Reset()
 }