-
-
Notifications
You must be signed in to change notification settings - Fork 348
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
expand: reimplement globstar globbing for correctness
The previous globstar implementation was breadth-first search, whereas Bash implements depth-first search. Moreover, when recursing into directories, we could stop early and give an error to the user when encountering a non-directory. Instead, we want to simply not recurse into that path. Add tests for both cases, too. Fixes #829.
- Loading branch information
Showing
2 changed files
with
44 additions
and
23 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters