Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for staticcheck's //lint:ignore directives #7

Closed
fsouza opened this issue Apr 10, 2019 · 3 comments
Closed

Support for staticcheck's //lint:ignore directives #7

fsouza opened this issue Apr 10, 2019 · 3 comments

Comments

@fsouza
Copy link

fsouza commented Apr 10, 2019

Currently, gofumpt adds a space after // and that causes staticcheck to not recognize the directive.
fsouza added a commit to fsouza/go-dockerclient that referenced this issue Apr 10, 2019
@fsouza
Run gofumpt
d4eec63 
Applied partially and manually filtered the result (see mvdan/gofumpt#7).

Not setting up any automations at this point.
@dominikh
Copy link

:-(

@mvdan
Copy link
Owner

mvdan commented Apr 11, 2019

Thanks - there were more directives than I thought. It doesn't help that there isn't really one standard syntax for them. I'll make the rule less agressive, but probably tomorrow as I need to sleep.

@mvdan mvdan closed this as completed in 7cf08f7 Apr 11, 2019
@mvdan
Copy link
Owner

mvdan commented Apr 11, 2019

I've made the solution somewhat generic, so other //foo:bar directives should be left alone too.

@AlekSi AlekSi mentioned this issue Jan 19, 2021
Closed
@ccoVeille ccoVeille mentioned this issue May 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dominikh @fsouza @mvdan