Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WSA action bug which breaks Home Assistant ONVIF component #1206

Merged
merged 1 commit into from
Aug 15, 2021
Merged

Conversation

slydiman
Copy link
Contributor

@slydiman slydiman commented Apr 1, 2021

Fix 400 Bad Request response to RenewRequest because Action and other addressing data is missing in the header.
#1205

Fix 400 Bad Request response to RenewRequest because Action and other addressing data is missing in the header.
#1205
@slydiman slydiman changed the title Update soap.py Fix WSA action bug which breaks Home Assistant ONVIF component Apr 19, 2021
@slydiman
Copy link
Contributor Author

Ping.

@sag3ll0
Copy link

sag3ll0 commented May 11, 2021

Yes its break HA. This fix is needed

@mvantellingen mvantellingen merged commit 015588d into mvantellingen:master Aug 15, 2021
@mvantellingen
Copy link
Owner

Merged, although i do wonder about if this is the correct way. We are now always adding WSA afaik

@mvantellingen
Copy link
Owner

Just reverted it again, needs more thinking (if you always want WSA you could just list it in the plugins)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants