Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If I have not set a rightViewController, there should not be a right bezel. #56

Merged
merged 1 commit into from
Jul 16, 2013

Conversation

kcharwood
Copy link
Contributor

I am using MMOpenDrawerGestureModeBezelPanningCenterView, and initialized my MMDrawerController with initWithCenterViewController:leftDrawerViewController:. In this case I feel like there should not be a right hand bezel, as it essentially creates a dead zone for swipe gestures on the right hand side of the screen.

@kcharwood
Copy link
Contributor

Ya I can buy that :)

Let me take a stab at it real quick.

@kcharwood
Copy link
Contributor

@larsacus feel free to check me there. Seems good on my end.

@ghost ghost assigned larsacus Jul 10, 2013
}
return shouldReceiveTouch;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes in this method don't do anything functionally different than they were before. Any reason for changing it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was just debugging and it was easier to see the value. Also cleaned it up to only have one return in the method.

@larsacus
Copy link
Contributor

Looks good to me. Some common code could be a little DRYer by combining the two new methods into something like isPointInBezelZone:(CGPoint)point forSide:(MMDrawerSide)side, but that would only save a couple of lines of code.

@tumatauenga
Copy link
Author

Hey guys, thanks a lot for your work on this, much appreciated! Any idea when it will make its way into the master branch? I'm about to release an app with this functionality, and would love for this to be included.

kcharwood added a commit that referenced this pull request Jul 16, 2013
If I have not set a rightViewController, there should not be a right bezel.
@kcharwood kcharwood merged commit a1a2b47 into master Jul 16, 2013
@kcharwood
Copy link
Contributor

There ya go @tumatauenga :)

@tumatauenga
Copy link
Author

Awesome thanks @kcharwood. FYI you might want to also update the tag / podspec.

@kcharwood
Copy link
Contributor

I'm planning on releasing 0.3.0 once we get #25 resolved.

@tumatauenga
Copy link
Author

No problem, will point to HEAD or that specific commit with cocoapods in the meantime, thanks again.

@kcharwood kcharwood deleted the 56_bezel_refactor branch August 12, 2013 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants