-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If I have not set a rightViewController, there should not be a right bezel. #56
Conversation
Ya I can buy that :) Let me take a stab at it real quick. |
@larsacus feel free to check me there. Seems good on my end. |
} | ||
return shouldReceiveTouch; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes in this method don't do anything functionally different than they were before. Any reason for changing it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was just debugging and it was easier to see the value. Also cleaned it up to only have one return in the method.
Looks good to me. Some common code could be a little DRYer by combining the two new methods into something like |
Hey guys, thanks a lot for your work on this, much appreciated! Any idea when it will make its way into the master branch? I'm about to release an app with this functionality, and would love for this to be included. |
If I have not set a rightViewController, there should not be a right bezel.
There ya go @tumatauenga :) |
Awesome thanks @kcharwood. FYI you might want to also update the tag / podspec. |
I'm planning on releasing 0.3.0 once we get #25 resolved. |
No problem, will point to HEAD or that specific commit with cocoapods in the meantime, thanks again. |
I am using MMOpenDrawerGestureModeBezelPanningCenterView, and initialized my MMDrawerController with initWithCenterViewController:leftDrawerViewController:. In this case I feel like there should not be a right hand bezel, as it essentially creates a dead zone for swipe gestures on the right hand side of the screen.