Fixed Issue #152 & improved iOS 7 status bar view #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By fixing #152 I discovred that there was also no longer the need for `dummyStatusBarView`. MMDrawerContoller's view can simply be used to display the `statusBarViewBackgroundColor`. It also has the benefit that the drawer's shadow doesn't get cut off.
kcharwood
added a commit
that referenced
this pull request
Jan 28, 2014
Fixed Issue #152 & improved iOS 7 status bar view
|
I accidentally merged this in when I didn't intend to. Could you please open a separate pull request for your proposed status bar changes? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By fixing #152 I discovred that there was also no longer the need for
dummyStatusBarView. MMDrawerContoller's view can simply be used todisplay the
statusBarViewBackgroundColor. It also has the benefitthat the drawer's shadow doesn't get cut off at the top.