Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add clang-apply-replacements to the managed tools #38

Merged
merged 1 commit into from
Jan 28, 2024

Conversation

renefritze
Copy link
Contributor

I have a workflow that needs a two-step approach to applying suggested fixes by clang-tidy.
Which means I need the clang-apply-replacements binary to apply the suggestions recorded by clang-tidy.
I have only tested this for clang-17 as of yet. Please let me know if you'd generally accept this PR and I'd run the whole suite in my fork too.

@muttleyxd
Copy link
Owner

Sorry for late response, last few months were pretty busy for me.

I'm all in for adding this, was this tool available earlier? I imagine it may have not been available for some older clang versions (like 3.9) - we could do two things here:

  • drop older clang versions - this may be a good idea - older releases will still be available - and it will make the whole pipeline less complicated
  • skip building this tool for older clang versions (probably less work)

@renefritze
Copy link
Contributor Author

I'm trying to build for all versions now: https://github.com/renefritze/clang-tools-static-binaries/actions/runs/7679580004

If there are failures, I'll drop those older versions for this PR

@renefritze renefritze marked this pull request as ready for review January 28, 2024 00:11
@renefritze
Copy link
Contributor Author

All green 🚀

@muttleyxd muttleyxd merged commit f7f02c1 into muttleyxd:master Jan 28, 2024
@renefritze renefritze deleted the add_apply_fixes branch January 28, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants