Fix Clang 12.0.1 and add Clang 13 #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muttleyxd
force-pushed
the
clang-12-0-1
branch
from
4d52b21 to
b9d83e9
Compare
|
Thank you for looking into this! |
GitHub Actions is not able to compare version string (ex. '12.0.1') to an integer value. Another way to fix this would be extracting major version from version string.
muttleyxd
force-pushed
the
clang-12-0-1
branch
2 times, most recently
from
bcb7f28 to
9f9cf99
Compare
Closed
WolleTD
reviewed
Nov 12, 2021
| @@ -88,7 +90,7 @@ jobs: | |||
| curl -LO https://github.com/llvm/llvm-project/releases/download/llvmorg-${version}/cfe-${version}.src.tar.xz | |||
| curl -LO https://github.com/llvm/llvm-project/releases/download/llvmorg-${version}/clang-tools-extra-${version}.src.tar.xz | |||
| - name: get llvm-project | |||
| if: ${{ matrix.clang-version >= 9 }} | |||
| if: ${{ matrix.clang-version >= 9 || matrix.clang-version == '12.0.1' }} | |||
There was a problem hiding this comment.
It's strange how the string 12.0.1 is apparently neither >= 9 nor < 7 (line 77). I would've expected it to be at least exactly one of those things. Even more so, because 3.9 < 7 actually works.
Edit: Well, 3.9 is a floating point number, 12.0.1 is not, duh. I still wonder what GH actions does there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13 and #11